feat(notice): add component tokens #11042
Conversation
github-actions
bot
added
the
enhancement
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Elijbet
removed
the
Stale
| * @prop --calcite-notice-close-text-color-hover: Specifies the background color of component's close button when hovered. | ||
| * @prop --calcite-notice-close-text-color: Specifies the text color of component's close button. | ||
| * @prop --calcite-notice-content-text-color: Specifies the content text color of the component. | ||
| * @prop --calcite-notice-width: Specifies the width of the component. |
There was a problem hiding this comment.
I wonder if we can evaluate this for removal. Not sure why we'd need this, vs. the user being able to set this.
There was a problem hiding this comment.
Yeah WDYT @alisonailea?
There was a problem hiding this comment.
I agree we could set this for removal
There was a problem hiding this comment.
@DitwanP @geospatialem is there any specific process/term we need for deprecation and removal for this or just [Deprecated] note for now is enough?
There was a problem hiding this comment.
I think the [Deprecated] note is enough.
There was a problem hiding this comment.
@Elijbet We have a new deprecate conventional commit, so would recommend we use that approach for the deprecation so users are aware of the deprecation via our changelog.
There was a problem hiding this comment.
I will create a follow-up PR for this.
… elijbet/7180-notice-design-tokens
Elijbet
added
the
pr ready for visual snapshots
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Related Issue: #7180
Summary
Adds the following subcomponent tokens (CSS props):
--calcite-notice-background-color--calcite-notice-close-background-color-focus--calcite-notice-close-background-color-press--calcite-notice-close-text-color-hover--calcite-notice-close-text-color--calcite-notice-content-text-color