feat(autocomplete): highlight text matching the inputValue #11155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
driskull
added
the
no changelog entry
driskull
added
the
pr ready for visual snapshots
driskull
added
pr ready for visual snapshots
driskull
added
pr ready for visual snapshots
jcfranco
reviewed
Dec 30, 2024
packages/calcite-components/src/components/autocomplete-item/resources.ts
Outdated
Show resolved
Hide resolved
| @@ -61,6 +61,12 @@ | |||
| color: var(--calcite-autocomplete-heading-text-color, var(--calcite-color-text-1)); | |||
| } | |||
|
|
|||
| .text-match { | |||
There was a problem hiding this comment.
Since you're adding a reusable util, can we move this into a mixin?
There was a problem hiding this comment.
The mixin doesn't make sense at this time since the styles between autocomplete and combobox are not consistent. Hopefully #11173 can resolve that.
There was a problem hiding this comment.
Sounds good. I'll add a note about this to the issue.
packages/calcite-components/src/components/autocomplete/autocomplete.tsx
Outdated
Show resolved
Hide resolved
driskull
added
pr ready for visual snapshots
5 tasks
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #11154
Summary
autocomplete-itemelementsBEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE