Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linting): clean up cspell warnings #11164

Merged
merged 3 commits into from
Jan 10, 2025
Merged

chore(linting): clean up cspell warnings #11164

merged 3 commits into from
Jan 10, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 29, 2024

Related Issue: N/A

Summary

  • adds custom dictionaries for
    • examples (dict-calcite-design-system-examples) and
    • cspell-dicts contribution candidates (dict-cspell-pending-upstream)
    • Spanish and Arabic words were explicitly added instead of using their respective dictionaries to keep linting speedy
  • replaces alt lorem-ipsum text with original version
  • adds patterns for common words
  • explicitly ignores rule for test hex codes used in color-picker-related tests
  • fixes cspell errors
  • fixes duplicate test name errors

Next steps

Create follow-up issues to:

  • contribute candidates
  • update doc with guidance (e.g., use hyphens instead of creating compound words, use sequential letters/digits when adding random or long text, etc...)
  • discuss and define process for keeping track of words
  • improve config (e.g., scope rules/dictionaries to relevant paths)
  • clean up custom dictionaries

@jcfranco jcfranco requested a review from benelan as a code owner December 29, 2024 03:28
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Dec 29, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 29, 2024
@jcfranco jcfranco changed the title chore: clean up cspell errors chore(linting): clean up cspell warnings Dec 30, 2024
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🏆 🧹

@jcfranco
Copy link
Member Author

update doc with guidance (e.g., use hyphens instead of creating compound words, use sequential letters/digits when adding random or long text, etc...)

Added wiki page: https://github.com/Esri/calcite-design-system/wiki/spelling-warnings

@jcfranco jcfranco merged commit 108620b into dev Jan 10, 2025
8 checks passed
@jcfranco jcfranco deleted the jcfranco/tidy-up-dicts branch January 10, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants