Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(combobox, input-time-zone): highlight text matches consistently #11193

Merged

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 2, 2025

Related Issue: #11173

Summary

This also introduces a mixin for shared text highlighting styles.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jan 2, 2025
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 2, 2025
@jcfranco jcfranco requested review from driskull and ashetland January 3, 2025 00:07
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🎉

@jcfranco
Copy link
Member Author

jcfranco commented Jan 3, 2025

@ashetland There weren't any relevant diffs reported from this change. I think these screenshots are affected by rendering timing.

Copy link

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jcfranco jcfranco added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 3, 2025
@jcfranco jcfranco merged commit 75f54de into dev Jan 3, 2025
14 checks passed
@jcfranco jcfranco deleted the jcfranco/11173-make-highlight-text-matching-consistent branch January 3, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants