fix(time-picker): display correct localized hour based on hour-format when no value is set #11200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when no value is set
github-actions
bot
added
the
bug
…isplay tests, moving 2 it blocks related to focus behavior into the focusing describe block, adding hour-format to defaults test, updating hour typing test to use hour-format 12 and 24
jcfranco
added
the
no changelog entry
jcfranco
approved these changes
Jan 4, 2025
packages/calcite-components/src/components/time-picker/time-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/time-picker/time-picker.e2e.ts
Show resolved
Hide resolved
packages/calcite-components/src/components/time-picker/time-picker.e2e.ts
Show resolved
Hide resolved
eriklharper
added
the
pr ready for visual snapshots
eriklharper
deleted the
eriklharper/11198-time-picker-wrong-initial-hour
branch
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #11198
Summary
This PR fixes an issue where if no valid time value is currently set, the
time-pickercomponent doesn't display the hour in the correspondinghour-format.BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE