Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(linting): restore consistent linting on JS/TS files #11204

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

chore(linting): restore consistent linting on JS/TS files #11204

wants to merge 1 commit into from
+3 −14

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 4, 2025 •
edited
Loading

Related Issue: N/A

Summary

Fixes an issue where JS/TS files were no longer being linted on commit after #10938 was merged.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jan 4, 2025
@jcfranco jcfranco marked this pull request as draft January 4, 2025 09:50
benelan
benelan reviewed Jan 5, 2025
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I switched to multiple lintstagedrc files because they had to be next to the eslint configs for the typescript parser to work. I'm not 100% sure though, it's been a while. I can do some testing Monday or Tuesday.

@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 6, 2025
@jcfranco
Copy link
Member Author

jcfranco commented Jan 7, 2025

@benelan Let's sync up on this tomorrow. I whipped this up to address the calcite-components package no longer being linted, but this has some issues when it comes to linting other packages (namely, ESLint configs not matching staged files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan left review comments

@alisonailea alisonailea alisonailea approved these changes

@geospatialem geospatialem Awaiting requested review from geospatialem geospatialem is a code owner

Assignees

@jcfranco jcfranco

Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @alisonailea @benelan