Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tile): remove unused data attributes #11216

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

refactor(tile): remove unused data attributes #11216

wants to merge 2 commits into from
+760 −2,327

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 7, 2025 •
edited
Loading

Related Issue: N/A

Summary

✨🧹✨

Note: #11215 should be merged prior to this.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 7, 2025
@jcfranco jcfranco changed the title fix(tile-group): keep selection icon size consistent for large tiles refactor(tile): remove unused data attributes Jan 7, 2025
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 7, 2025
@jcfranco jcfranco requested a review from eriklharper January 7, 2025 23:59
@eriklharper
Copy link
Contributor

eriklharper commented Jan 8, 2025 •
edited
Loading

Note: #11216 should be merged prior to this.

Did you mean to link to #11215 instead?

eriklharper
eriklharper approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@eriklharper eriklharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attribute removal changes look good to me. Once #11215 merges, this should be good to go! :)

@jcfranco
Copy link
Member Author

jcfranco commented Jan 8, 2025 •
edited
Loading

Did you mean to link to #11215 instead?

Whoops, yes. 😅 Thanks for the catch! 🎣

@jcfranco jcfranco marked this pull request as ready for review January 8, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriklharper eriklharper eriklharper approved these changes

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @eriklharper