-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure components are disabled consistently #4108
Closed
jcfranco
wants to merge
66
commits into
master
from
jcfranco/2655-apply-consistent-disabled-behavior
Closed
fix: ensure components are disabled consistently #4108
jcfranco
wants to merge
66
commits into
master
from
jcfranco/2655-apply-consistent-disabled-behavior
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
Bug reports for broken functionality. Issues should include a reproduction of the bug.
label
Feb 14, 2022
Going to rebase and resubmit once more. This PR has the same issue as #4010 (Screener check not reporting). |
jcfranco
deleted the
jcfranco/2655-apply-consistent-disabled-behavior
branch
February 15, 2022 04:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #2655
Summary
This establishes a pattern to handle the disabling of interactive components.
Implementation of interactive components should follow these steps:
InteractiveComponent
interface.updateHostInteraction
(src/utils/interactive.ts
) on the component'scomponentDidRender
lifecycle method – this will updatetabindex
andaria-disabled
attributes, accordingly.disabled
mixin fromsrc/assets/styles/includes.scss
– this provides the base styles for disabled components.disabled
on any supporting, internal components (e.g.,<calcite-slider>
disables internal<button>
s).disabled
test helper (src/tests/commonTests
).Notes
disabled components set
tabIndex
on the host and assume it will not be modified by end-users - it is set on the host to prevent tabbing into children:From WICG/inert#48:
disabling a component with an active popover will close it and prevent programmatically opening it
calcite-label
'sdisabled
property is deprecatedtweaked styles and rendering of
calcite-input-date-picker
to avoid pointer-events overrides.programmatically disabling a component that owns focus will not affect the focus order. For example, if the color picker's hex input is focused and some extraneous code disables the color picker, a user would still be able to tab within the the color picker's focusable controls. I think this won't be feasible in a performant way until
inert
is implemented across browsers. FWIW, I don't think this will be an issue for most use cases, but we'll have to see. As a workaround, endusers could focus another element when disabling a focus-owning component.Some components emit one or more click events from implementation, I'll create a separate issue for this.
Disabled components get their
HTMLElement#click()
hijacked to prevent programmatic clicking.The following components were updated to follow the same
disabled
behavior:calcite-action.tsx
calcite-block.tsx
calcite-button.tsx
calcite-checkbox.tsx
calcite-color-picker.tsx
calcite-combobox-item.tsx
calcite-combobox.tsx
calcite-date-picker-day.tsx
calcite-dropdown.tsx
calcite-fab.tsx
calcite-filter.tsx
calcite-inline-editable.tsx
calcite-input-date-picker.tsx
calcite-input-time-picker.tsx
calcite-input.tsx
calcite-link.tsx
calcite-list-item.tsx
calcite-list.tsx
calcite-panel.tsx
calcite-pick-list.tsx
calcite-radio-button.tsx
calcite-radio-group.tsx
calcite-rating.tsx
calcite-select.tsx
calcite-slider.tsx
calcite-sortable-list.tsx
calcite-split-button.tsx
calcite-stepper-item.tsx
calcite-switch.tsx
calcite-tab-title.tsx
calcite-tile-select.tsx
calcite-tile-select-group.tsx
calcite-tile.tsx
calcite-value-list.tsx
Pending
Questions
calcite-label
needdisabled
? Is it considered interactive? It only forwards the click on labelable components. – will deprecate as disabled label behavior depends on labelable componentcalcite-stepper
to keep overriding pointer events on items to display the disabled (not-allowed
) cursor?– the pointer-events override & custom cursor will be removed for consistency