Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero Banner CTA Modal #541

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Hero Banner CTA Modal #541

merged 4 commits into from
Feb 10, 2025

Conversation

jsavella
Copy link
Contributor

@jsavella jsavella commented Feb 6, 2025

@jsavella jsavella self-assigned this Feb 6, 2025
Copy link

aem-code-sync bot commented Feb 6, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Feb 6, 2025

Page Scores Audits Google
📱 /en-us/about/about-esri/overview PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /en-us/about/about-esri/overview PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@twhite313 twhite313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escape key doesn't close modal.
Modal sits below nav and other page elements
Page is still scrollable -- shouldn't be. Should be locked to modal.

Uploading modal-below other items.png…

@twhite313 Pushed updates.

@jsavella jsavella merged commit 582eded into main Feb 10, 2025
2 checks passed
@jsavella jsavella deleted the hbModal branch February 10, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HERO BANNER: cta modal implementation
3 participants