Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to rollup-plugin-terser #1316

Merged
merged 2 commits into from
Feb 23, 2022
Merged

switch to rollup-plugin-terser #1316

merged 2 commits into from
Feb 23, 2022

Conversation

gavinr
Copy link
Contributor

@gavinr gavinr commented Feb 22, 2022

Switching from rollup-plugin-uglify to rollup-plugin-terser.

This PR replaces #1235, but @jwasilgeo's comment still applies:

If this change goes through, then I suggest we also think about updating these plugins' npm deps that rely on esri-leaflet's own Rollup config:

@gavinr gavinr requested a review from jwasilgeo February 22, 2022 23:31
@gavinr gavinr merged commit ecd369e into Esri:master Feb 23, 2022
@gavinr gavinr deleted the terser-3 branch February 23, 2022 21:01
gavinr pushed a commit to Esri/esri-leaflet-cluster that referenced this pull request Feb 24, 2022
@gavinr-maps
update dependencies and switch to rollup-plugin-terser
9697fbf 
update to latest dependencies that esri-leaflet is using and also switch to rollup-plugin-terser (like Esri Leaflet Esri/esri-leaflet#1316)
@gavinr gavinr mentioned this pull request Feb 24, 2022
Merged
gavinr pushed a commit to gavinr/esri-leaflet-geocoder that referenced this pull request Feb 28, 2022
@gavinr-maps
updated to rollup-plugin-terser
25e674e 
Esri/esri-leaflet#1316
jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
@gavinr
switch to rollup-plugin-terser (Esri#1316)
e2e32dd 
* switch to rollup-plugin-terser

* fix quotes
jgravois pushed a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
@gavinr
switch to rollup-plugin-terser (Esri#1316)
3ac43f6 
* switch to rollup-plugin-terser

* fix quotes
@gavinr gavinr mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwasilgeo jwasilgeo jwasilgeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavinr @jwasilgeo @gavinr-maps