Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate @esri/hub-types and @esri/hub-auth into @esri/hub-common #383

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

tomwayson
Copy link
Member

@tomwayson tomwayson commented Sep 21, 2020

consolidate @esri/hub-types and @esri/hub-auth into @esri/hub-common

First step towards #306

affects: @esri/hub-common, @esri/hub-sites, @esri/hub-teams
@tomwayson
Copy link
Member Author

tomwayson commented Sep 21, 2020

Note to self more than anything: will need to bump common and teams in sites' peerDependencies when cutting the release

@tomwayson tomwayson changed the title refactor(types): remove hub-types and move types into other packges consolidate @esri/hub-types and @esri/hub-auth into @esri/hub-common Sep 22, 2020
@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0d1f2e3). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master      #383   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?       390           
  Lines             ?      4613           
  Branches          ?       634           
==========================================
  Hits              ?      4613           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
packages/common/src/auth.ts 100.00% <ø> (ø)
...kages/sites/src/create-site-model-from-template.ts 100.00% <ø> (ø)
packages/sites/src/drafts/apply-draft.ts 100.00% <ø> (ø)
packages/teams/src/create-hub-teams.ts 100.00% <ø> (ø)
packages/teams/src/types.ts 100.00% <ø> (ø)
packages/teams/src/utils/_create-team-group.ts 100.00% <ø> (ø)
packages/teams/src/utils/_create-team-groups.ts 100.00% <ø> (ø)
...ckages/teams/src/utils/_translate-team-template.ts 100.00% <ø> (ø)
...teams/src/utils/can-user-create-team-in-product.ts 100.00% <ø> (ø)
packages/teams/src/utils/can-user-create-team.ts 100.00% <ø> (ø)
... and 401 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1f2e3...674d3f5. Read the comment docs.

Copy link
Contributor

@cpgruber cpgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. will this be a major release since we're removing packages?

@tomwayson
Copy link
Member Author

No, b/c we're not removing anything within any package. I will deprecate the deleted packages in npm.

@tomwayson tomwayson merged commit aae0dbc into master Sep 22, 2020
@tomwayson tomwayson deleted the c/no-types branch September 22, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants