Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move teams fns to hub common #657

Closed
wants to merge 2 commits into from
Closed

move teams fns to hub common #657

wants to merge 2 commits into from

Conversation

tomwayson
Copy link
Member

@tomwayson tomwayson commented Oct 1, 2021

  1. Description:

The next step towards one package to rule them all!!!

part of #655

after releasing this, we would:

  • remove the @esri/hub-teams dependency from the Hub app, hub-components, Solutions.js, template-js
  • and bump those packages to @esri/hub-common@^8.25.0 and @esri/hub-sites@^8.25.0 as needed
  • then find and replace any imports from @esri/hub-teams to @esri/hub-common
  • finally deprecate the teams @esri/hub-teams package on npm

NOTE: the teams source code will always be available at:

https://github.com/Esri/hub.js/tree/1290da6bae03f66b9b74c797932b88a395371573/packages/teams

  1. Instructions for testing:

  2. ran commit script (npm run c)

affects: @esri/hub-common, @esri/hub-sites

removes packages/teams
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #657 (da1ee74) into master (efa11e1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #657   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          461       461           
  Lines         6609      6609           
  Branches      1051      1052    +1     
=========================================
  Hits          6609      6609           
Impacted Files Coverage Δ
...es/common/src/teams/add-or-invite-users-to-team.ts 100.00% <ø> (ø)
...s/common/src/teams/add-or-invite-users-to-teams.ts 100.00% <ø> (ø)
packages/common/src/teams/add-users-to-team.ts 100.00% <ø> (ø)
packages/common/src/teams/create-hub-team.ts 100.00% <ø> (ø)
packages/common/src/teams/create-hub-teams.ts 100.00% <ø> (ø)
packages/common/src/teams/index.ts 100.00% <ø> (ø)
...ackages/common/src/teams/remove-users-from-team.ts 100.00% <ø> (ø)
...ckages/common/src/teams/remove-users-from-teams.ts 100.00% <ø> (ø)
packages/common/src/teams/types.ts 100.00% <ø> (ø)
packages/common/src/teams/update-team.ts 100.00% <ø> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa11e1...da1ee74. Read the comment docs.

Copy link
Member

@benstoltz benstoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. Are you going to handle updating the references in od-ui once this gets released?

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Oct 5, 2021
@benstoltz benstoltz added Draft Draft PR or Issue (don't mark stale) and removed Stale Stale issue - update or it will be closed labels Oct 6, 2021
@tomwayson tomwayson marked this pull request as draft October 11, 2021 14:22
@tomwayson
Copy link
Member Author

we still want to do this, but I'm closing this PR as it is too far out of date

@tomwayson tomwayson closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Draft Draft PR or Issue (don't mark stale)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants