-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move teams fns to hub common #657
Conversation
…b-common affects: @esri/hub-teams
affects: @esri/hub-common, @esri/hub-sites removes packages/teams
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 461 461
Lines 6609 6609
Branches 1051 1052 +1
=========================================
Hits 6609 6609
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me. Are you going to handle updating the references in od-ui once this gets released?
There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label. |
we still want to do this, but I'm closing this PR as it is too far out of date |
The next step towards one package to rule them all!!!
part of #655
after releasing this, we would:
@esri/hub-teams
dependency from the Hub app, hub-components, Solutions.js, template-js@esri/hub-common@^8.25.0
and@esri/hub-sites@^8.25.0
as needed@esri/hub-teams
to@esri/hub-common
@esri/hub-teams
package on npmNOTE: the teams source code will always be available at:
https://github.com/Esri/hub.js/tree/1290da6bae03f66b9b74c797932b88a395371573/packages/teams
Instructions for testing:
ran commit script (
npm run c
)