Change Test Imports to point to arcgisRestJS #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reference changes
making wrapper export functions to get around error Error: <spyOn> : <functon or property> is not declared writable or has no setter
more wrapper functions
Updated test; added interfaces; completed code coverage
turning back on dots.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1507 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 152 152
Lines 8143 8168 +25
Branches 1863 1863
=========================================
+ Hits 8143 8168 +25 ☔ View full report in Codecov by Sentry. |
MikeTschudi
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing changing all the direct arcgis-rest-js imports from other tests to use the arcgisRestJS module.
Some test failed throwing this error
Error: : is not declared writable or has no setter
So I had to make wrapper functions to have a writable function that calls the arcgis rest js function under the hood.
