Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for not creating solution item during deployment #1514

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

MikeTschudi
Copy link
Member

#1512

Because a solution is not created during deployment, a GUID is generated to take the place of its id for tasks such as described in #35. This GUID comes from the platform crypto.randomUUID function; if that function is not available, Math.random is used, subject to the rules of GUIDs (see https://en.wikipedia.org/wiki/Universally_unique_identifier, section "Version 4 (random)")

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (778318b) to head (296f707).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1514   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          153       153           
  Lines         8199      8215   +16     
  Branches      1811      1876   +65     
=========================================
+ Hits          8199      8215   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MikeTschudi MikeTschudi requested a review from jmhauck November 25, 2024 22:05
@MikeTschudi MikeTschudi merged commit 42b714a into develop Nov 27, 2024
9 checks passed
@MikeTschudi MikeTschudi deleted the enh/1512-make-deployed-soln-item-optional branch November 27, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants