Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UKeyboard: Add KEY_NUMPADENTER and isEnterKey method #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UKeyboard: Add KEY_NUMPADENTER and isEnterKey method #74

wants to merge 1 commit into from
+7 −0

Conversation

Sychic
Copy link
Member

@Sychic Sychic commented Jul 10, 2024

isEnterKey could be moved to inside of Essential but would be useful for those trying to do something similar to what we do in Essential.

Related: EM-2693

@Sychic Sychic requested a review from Johni0702 July 10, 2024 22:05
caoimhebyrne
caoimhebyrne approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@caoimhebyrne caoimhebyrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about the naming of isEnterKey, could be something like isAnyEnterKey, but the fact that it exists probably indicates that it checks for either of them - so that's fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caoimhebyrne caoimhebyrne caoimhebyrne approved these changes

@Johni0702 Johni0702 Awaiting requested review from Johni0702

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sychic @caoimhebyrne