Standalone: Fix slf4j logging and add default log4j config #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use version 2 of slf4j, so we need to include the log4j adapter which was built for version 2, not the one for version 1. With that, logging works, but it's using log4j's ugly default format and only emits WARN or above. To improve the out-of-the-box behavior for Standalone UC, we add a default log4j config file; applications which require further customization can override it via one of the many way which log4j provides.
DJtheRedstoner
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use version 2 of slf4j, so we need to include the log4j adapter which was built for version 2, not the one for version 1.
With that, logging works, but it's using log4j's ugly default format and only emits WARN or above.
To improve the out-of-the-box behavior for Standalone UC, we add a default log4j config file; applications which require further customization can override it via one of the many way which log4j provides.