Skip to content

Switch to configuration based events on Paper #6248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: 2.x
Choose a base branch
from

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Aug 3, 2025

Moves away from PlayerLoginEvent on Paper and makes use of the new configuration state to load user/locale data during configuration phase. Not only does this ensure all I/O is done async before the player even joins but also finally allows us to actually set the join message in the PlayerJoinEvent.

This also fixes #5796 and closes #5848

@JRoy JRoy added this to the 2.22.0 milestone Aug 3, 2025
@JRoy JRoy added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module labels Aug 3, 2025
@JRoy JRoy marked this pull request as ready for review August 4, 2025 05:24
@R00tB33rMan
Copy link

Moves away from PlayerLoginEvent on Paper and makes use of the new configuration state to load user/locale data during configuration phase. Not only does this ensure all I/O is done async before the player even joins but also finally allows us to actually set the join message in the PlayerJoinEvent.

This also fixes #5796 and closes #5848

Not sure if this is out of scope for this PR; however, the PlayerLoginEvent is now considered deprecated on newer versions of Paper. Maybe the AsyncPlayerPreLoginEvent should be used instead?

@JRoy
Copy link
Member Author

JRoy commented Aug 4, 2025

Moves away from PlayerLoginEvent on Paper and makes use of the new configuration state to load user/locale data during configuration phase. Not only does this ensure all I/O is done async before the player even joins but also finally allows us to actually set the join message in the PlayerJoinEvent.

This also fixes #5796 and closes #5848

Not sure if this is out of scope for this PR; however, the PlayerLoginEvent is now considered deprecated on newer versions of Paper. Maybe the AsyncPlayerPreLoginEvent should be used instead?

this pr moves us away from the PlayerLoginEvent on paper :))

@R00tB33rMan
Copy link

Moves away from PlayerLoginEvent on Paper and makes use of the new configuration state to load user/locale data during configuration phase. Not only does this ensure all I/O is done async before the player even joins but also finally allows us to actually set the join message in the PlayerJoinEvent.
This also fixes #5796 and closes #5848

Not sure if this is out of scope for this PR; however, the PlayerLoginEvent is now considered deprecated on newer versions of Paper. Maybe the AsyncPlayerPreLoginEvent should be used instead?

this pr moves us away from the PlayerLoginEvent on paper :))

Ah yeah, must’ve misread. I saw the event still used elsewhere without realizing that it was intended for Spigot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minecraft default join message is not translated
2 participants