Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] A11y for 3.8.2 #1219

Merged
merged 6 commits into from
Oct 29, 2024
Merged

[DONE] A11y for 3.8.2 #1219

merged 6 commits into from
Oct 29, 2024

Conversation

Badatos
Copy link
Collaborator

@Badatos Badatos commented Oct 15, 2024

  • Minor code formatting
  • Add missing DocStrings
  • Modify some redundant title strings, adding the targeted object
  • Remove some redundant titles
  • Correct i18n strings
  • Correct duplicated id
  • remove broken aria-label id
  • Add flatpage title in h1 for accessibility + remove H1 title in legal notice and accessibility statement pages
  • upgrade gitguardian config version
  • Update .po/mo lang files

@Badatos Badatos self-assigned this Oct 15, 2024
* Code formatting
* Modify some redundant title strings, adding the targeted object
* Remove some redundant titles
* Correct i18n strings
* Correct duplicated id
* remove broken aria-label id
…al notice and accessibility statement pages

* upgrade gitguardian config version
* Update .po/mo lang files
@Badatos Badatos marked this pull request as ready for review October 17, 2024 15:18
@Badatos Badatos changed the title [WIP] A11y for 3.8.2 [DONE] A11y for 3.8.2 Oct 17, 2024
@LoicBonavent LoicBonavent self-requested a review October 18, 2024 06:35
Copy link
Collaborator

@LoicBonavent LoicBonavent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci d'être passé sur autant de fichiers ! Nickel

Copy link
Collaborator

@gcondess gcondess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAS

@Badatos Badatos merged commit e1cad6f into EsupPortail:develop Oct 29, 2024
3 checks passed
@Badatos Badatos deleted the A11y_for_3.8.2 branch October 29, 2024 08:27
Badatos added a commit that referenced this pull request Oct 29, 2024
## New functionalities:
* Use Whisper to format vtt subtitle (#1187)
* Remove BBB module and add sipmediagw feature (#1190)
* Add NOTIFY_SENDER boolean parameter (#1192)
* Add fields to recording rest response (#1193)
* Add return thumbnail url,width and height to oembed (#1194)
* Add optional proxy URL for request coming from Aristote (#1218)

## Bugs corrected:
* Change all filter_fields = () in filterset_fields = [], as filter_fields is deprecated  (#1191)
* Fix multi carousel (#1200)
* Change regroup videos by theme when ORGANIZE_BY_THEME = True (#1203)
* Bug habillage (#1211)
* Fix migration script for BBB (#1214)
* Improve RSS Feeds (#1215)
* Fix BBB meeting deletion link (issue #1216)
* No crop on thumbnail (#1217)
* Use `get_thumbnail` to serve video thumbnail via caching system, to prevent video folder url to be publicly available (#1221)
* Addition of a toolbar in the theme description editor of a chain. (issue #1185)
* Correction enabling channels and themes to be assigned to a set of videos (issue #1106)
* Manage restricted video access right in playlist

## Accessibility improvements: (#1219)
* Modify some redundant title strings, adding the targeted object
* Remove some redundant titles
* Correct i18n strings
* Correct duplicated id
* Remove broken aria-label id
* Add flatpage title in h1 for accessibility + remove H1 title in legal notice and accessibility statement pages

## Quality of Code:
* Minor code formatting
* Add missing DocStrings
* Upgrade GitGuardian config version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants