Skip to content

Commit

Permalink
Bug affecting Nord range thumb border
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Dunn committed Nov 15, 2023
1 parent 4296609 commit 142237e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 12 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@ Note that the base color definitinons change in dark theme.
--border-width: 1px;

/*Inputs, buttons, etc*/
--control-height: 3ex;
--control-border-radius: 12px;
--control-height: 1.6rem;
--control-border-radius: 0.8rem;
--control-border-width: 1px;

--3d-highlight: color-mix(in srgb, var(--box-bg) 50%, rgba(241, 241, 241, 0.695));
Expand Down Expand Up @@ -340,6 +340,7 @@ Note that the base color definitinons change in dark theme.
--table-border-strength: 50%;

--thin-border: 1px solid var(--border-color);
--control-border: var(--control-border-width) solid var(--control-border-color);
}
```

Expand Down
21 changes: 11 additions & 10 deletions css/barrel.css
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ h6 {
--table-border-strength: 50%;

--thin-border: 1px solid var(--border-color);
--control-border: var(--control-border-width) solid var(--control-border-color);
}

/*Less likely stuff for user to change, intermediate vars in complex logic*/
Expand Down Expand Up @@ -503,7 +504,7 @@ button,
input:is([type='submit'], [type='button']) {
background: var(--convex-item-bg);
text-decoration: none;
border: var(--control-border-width) solid var(--control-border-color);
border: var(--control-border);
color: var(--control-fg);
padding: 0em 0.2em 0em 0.2em;
display: inline-block;
Expand Down Expand Up @@ -715,7 +716,7 @@ header {

& input,
& label>input {
border: var(--control-border-width) solid var(--control-border-color);
border: var(--control-border);
}

}
Expand Down Expand Up @@ -1756,7 +1757,7 @@ footer.padding {
}

.tool-bar {
--tool-bar-element-border: var(--control-border-width) solid var(--control-border-color);
--tool-bar-element-border: var(--control-border);
--header-padding: 0px;
flex-basis: max-content;
display: flex;
Expand Down Expand Up @@ -2013,7 +2014,7 @@ footer.padding {
& meter::-webkit-meter-inner-element {
-webkit-appearance: inherit;
box-sizing: inherit;
border: var(--control-border-width) solid var(--control-border-color);
border: var(--control-border);
height: var(--control-height);
}

Expand Down Expand Up @@ -2114,7 +2115,7 @@ input[type=range] {

input[type="range"]::-webkit-slider-runnable-track {
background-color: color-mix(in srgb, var(--control-bg) 70%, var(--control-fg));
border: var(--thin-border);
border: var(--control-border);
border-radius: 250px;
height: calc(var(--control-height) / 3);
}
Expand All @@ -2124,15 +2125,15 @@ input[type=range]::-webkit-slider-thumb {
width: calc(var(--control-height) / 1.6);
height: calc(var(--control-height) / 1.2);
background-color: var(--highlight-color);
border: var(--thin-border);
border: var(--control-border);
border-width: 2px;
border-radius: 100px;
-webkit-appearance: none;
}

input[type="range"]::-moz-range-track {
background-color: color-mix(in srgb, var(--control-bg) 70%, var(--control-fg));
border: var(--thin-border);
border: var(--control-border);
border-radius: 250px;
height: calc(var(--control-height) / 3);
}
Expand All @@ -2141,7 +2142,7 @@ input[type=range]::-moz-range-thumb {
width: calc(var(--control-height) / 1.6);
height: calc(var(--control-height) / 1.2);
background-color: var(--highlight-color);
border: var(--thin-border);
border: var(--control-border);
border-width: 2px;
border-radius: 100px;
}
Expand Down Expand Up @@ -2280,7 +2281,7 @@ input[type='radio'] {
appearance: none;
background: var(--concave-item-bg);
box-shadow: var(--concave-item-box-shadow);
border: var(--control-border-width) solid var(--control-border-color);
border: var(--control-border);
width: var(--control-height);
height: var(--control-height);
flex-grow: 0 !important;
Expand Down Expand Up @@ -2375,7 +2376,7 @@ input[type="checkbox"].toggle {
position: relative;
display: inline-block;
box-sizing: border-box;
border: var(--control-border-width) solid var(--control-border-color);
border: var(--control-border);
left: var(--slider-position);
top: var(--control-border-width);
vertical-align: middle;
Expand Down

0 comments on commit 142237e

Please sign in to comment.