Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding table readme #50

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

finxlfantasy
Copy link
Contributor

Description

Problem*

Making readme shorter by removing redundant text, and replacing it instead with a table.

Resolves #49 (comment)

Summary*

Replaces the long text in the feature section with a table.
Example as such:

features halo2-pse halo2-axiom
feature X supported supported
feature Y supported not supported
feature Z not supported supported

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@finxlfantasy finxlfantasy changed the title Adding table readme feat: Adding table readme Nov 30, 2023
@finxlfantasy finxlfantasy changed the title feat: Adding table readme fix: Adding table readme Nov 30, 2023
Copy link
Owner

@Ethan-000 Ethan-000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! :)

@Ethan-000 Ethan-000 merged commit fe08987 into Ethan-000:master Dec 1, 2023
6 of 8 checks passed
@finxlfantasy
Copy link
Contributor Author

Thank you Ethan, was my first PR lol.
By the way do you work with Aztec?

I've been learning Rust recently, and found it nice there is a DSL that's Rust based. Also looked at their ACVM docs.

@Ethan-000
Copy link
Owner

i worked with them during the summer. if you are interested in compilers and rust feel free to work on some issues there. they are generally nice and should be willing to get you started

@finxlfantasy
Copy link
Contributor Author

Nice! Yeah i'm really passionate about cryptography and security. Had some ideas to specialise in the niche of Rust smart contract auditing and/or development. I kind of have a fundamental understanding of the theory and math when it comes to zk and such.

@Ethan-000
Copy link
Owner

Yeah its a very interesting field 😂. I also like rust, zk, math etc 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding table for readme
2 participants