System Tray Improvements #79
Open
+27
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves menus on Windows as they use the L&F of the application. Additionally this fixes the system tray on Linux, as it was completely broken previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix system trays on Linux (in various desktop environments), as well as improve the look of them on Windows.
On Linux, the tray icon doesn't have a transparent background and cannot be interacted with. So if you click on "Send to tray" the application is hidden indefinitely and has to be killed manually.
I make use of dorkbox/SystemTray for this, it allows for native look and feel on may platforms, and on Windows follows the look and feel of the application.
Let me know if you'd like any changes :)