Fix/nullable team (#350)

Etimo · Nov 15, 2024 · 781fdf9 · 781fdf9
1 parent cd689c4
commit 781fdf9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/backend/src/models/highscore-public.dto.ts b/packages/backend/src/models/highscore-public.dto.ts
@@ -1,5 +1,6 @@
 import { IHighscoreDto } from "@etimo/diamonds2-types";
-import { ApiProperty } from "@nestjs/swagger";
+import { ApiProperty, ApiPropertyOptional } from "@nestjs/swagger";
+import { IsOptional } from "class-validator";
 import { IHighscore } from "../types";
 
 export class HighscorePublicDto implements IHighscoreDto {
@@ -12,8 +13,9 @@ export class HighscorePublicDto implements IHighscoreDto {
   @ApiProperty()
   seasonId!: string;
 
-  @ApiProperty()
-  team!: string;
+  @ApiPropertyOptional({ nullable: true })
+  @IsOptional()
+  team: string | null = null;
 
   @ApiProperty()
   teamLogotype!: string;
@@ -23,7 +25,7 @@ export class HighscorePublicDto implements IHighscoreDto {
       botName: entity.bot!.name,
       score: entity.score,
       seasonId: entity.seasonId,
-      team: entity.bot!.team!.name,
+      team: entity.bot!.team?.name ?? null,
       teamLogotype: entity.bot!.team!.logotypeUrl,
     };
   }

diff --git a/packages/types/src/dto/highscore-dto.ts b/packages/types/src/dto/highscore-dto.ts
@@ -2,6 +2,6 @@ export interface IHighscoreDto {
   botName: string;
   score: number;
   seasonId: string;
-  team: string;
+  team: string | null;
   teamLogotype: string;
 }