Fix https://github.com/warp-tech/russh/issues/232 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuela
force-pushed
the
samuela/keepalive
branch
from
55f3ad0 to
e3a0881
Compare
|
@mmirate could you please review this as well? Thanks. |
mmirate
suggested changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon debugging, I discovered that
alive_timeoutsis not currently ever reset to 0 anywhere. The diff inserver/session.rsremedies this, resetingalive_timeoutsto 0 any time we receive data from the client.Unfortunately, there was additionally the issue that
self.common.received_datawas not in fact a reliable indicator of whether or not we had actually received data from the client. This turned out to be due to some logic inserver/encrypted.rsthat overrode the assignment here if the message was not one of the expected format. I have removed this logic inserver/encrypted.rs.self.common.received_datais not documented or defined AFAIK. Looking through the code, I concluded thatserver/encrypted.rswas in the wrong and should be modified, but some scrutiny on this decision may be warranted. In any case, this fixes #232.