bump dependency versions to the minimum version that compiles. #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericseppanen
force-pushed
the
minimal_dependencies
branch
from
7c4beb2 to
7d03f30
Compare
These dependency versions are the minimum that can actually build. This allows a tool like `cargo minimal-versions` to verify that the code compiles even when using the oldest possible dependency versions, but is also a useful step toward verifying that the crates can be built on older toolchains.
ericseppanen
force-pushed
the
minimal_dependencies
branch
from
7d03f30 to
17fe12b
Compare
|
Looking good! I've added a CI job to run minimal-versions as well |
|
@all-contributors add @ericseppanen for code |
|
I've put up a pull request to add @ericseppanen! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency versions in Cargo.toml were inaccurate in places, because they allowed versions that don't actually work-- crates were enabling Cargo features that don't exist in those versions, or methods/traits/etc that didn't exist in the code.
This allows a tool like
cargo minimal-versionsto verify that the code compiles even when using the oldest possible dependency versions, but is also a useful step toward verifying that the crates can be built on older toolchains.Replaces #419.