Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLX port
With small changes it's possible to port the pytorch version to MLX.
Notes:
Adam
optimizer inMLX
doesn't supportweight_decay
(ref), so I've usedAdamW
. We'll probably want to useAdamW
in pytorch as well?Potential follow up work:
random = RNG(1337)
to somehow initialize the weights@mx.compile
Installation
Need to install
mlx
package (works on Apple silicon only):pip install mlx
.Results
I've gotten pretty similar results compared to the pytorch version.
Pytorch loss:
MLX: