Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add new workflow to build commits and output to s3 #3321

Closed
wants to merge 7 commits into from

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Nov 18, 2024

Overview

Given a commit hash and a build machine, outputs a python wheel to s3. This is slightly different than existing one. Differences:

  • machine type is configurable
  • machine types are not matrixified
  • is able to be triggered manually or via another workflow
  • commit is specifiable

@raunakab raunakab marked this pull request as ready for review November 18, 2024 19:37
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #3321 will degrade performances by 19.86%

Comparing feat/build-commit-workflow (ca82ffa) with main (274f300)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/build-commit-workflow Change
test_iter_rows_first_row[100 Small Files] 378.4 ms 258.6 ms +46.36%
test_show[100 Small Files] 23.9 ms 29.8 ms -19.86%

@github-actions github-actions bot added the enhancement New feature or request label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.38%. Comparing base (274f300) to head (ca82ffa).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3321      +/-   ##
==========================================
- Coverage   77.39%   77.38%   -0.01%     
==========================================
  Files         676      676              
  Lines       82604    82604              
==========================================
- Hits        63928    63925       -3     
- Misses      18676    18679       +3     

see 3 files with indirect coverage changes

---- 🚨 Try these New Features:

- slightly different than existing one
@raunakab raunakab force-pushed the feat/build-commit-workflow branch from c81c101 to f0c99eb Compare November 18, 2024 21:20
@raunakab
Copy link
Contributor Author

raunakab commented Nov 18, 2024

Running

Will be able to run via:

gh workflow run build-commit.yaml --ref my-branch-name

This does assume that you have the gh CLI tool installed. If you have a macOS or Linux system, you can install it via brew install gh. Once merged into main, you will also be able to manually trigger this via the GitHub Actions tab on the browser app.

Performance

Assuming a cache-miss, build times will usually be around 5-6min. Assuming a cache-hit, build times will usually be <40s.

@raunakab raunakab requested a review from samster25 November 18, 2024 21:25
.github/actions/install/action.yaml Outdated Show resolved Hide resolved
.github/workflows/build-commit.yaml Outdated Show resolved Hide resolved
@raunakab raunakab marked this pull request as draft November 19, 2024 18:27
@raunakab
Copy link
Contributor Author

raunakab commented Nov 20, 2024

Closing in favour of #3184.

@raunakab raunakab closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants