Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] connect test: df.get_attr #3349

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[CHORE] connect test: df.get_attr #3349

merged 1 commit into from
Nov 26, 2024
+15 −0

Conversation

andrewgazelka
Copy link
Contributor

No description provided.

@andrewgazelka andrewgazelka marked this pull request as ready for review November 20, 2024 06:57
@andrewgazelka Graphite App
Copy link
Contributor Author

andrewgazelka commented Nov 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 20, 2024
Merged
Merged
Closed
@andrewgazelka andrewgazelka force-pushed the andrew/connect-alias branch 2 times, most recently from 45be7ee to 1c7d6f5 Compare November 20, 2024 09:03
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from 7becfc6 to e84d0d7 Compare November 20, 2024 09:04
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from e84d0d7 to be1f3ab Compare November 20, 2024 18:26
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from be1f3ab to e38dde9 Compare November 20, 2024 18:33
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from e38dde9 to d97016a Compare November 20, 2024 18:44
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from d97016a to 29f4caa Compare November 20, 2024 18:49
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from 29f4caa to a7a07f5 Compare November 20, 2024 19:33
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from a7a07f5 to 7f9e011 Compare November 20, 2024 23:27
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch 2 times, most recently from 77fcdb6 to 890ed46 Compare November 20, 2024 23:30
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from 890ed46 to 7f32fa0 Compare November 21, 2024 00:39
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from 7f32fa0 to dfcbe19 Compare November 21, 2024 01:44
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from dfcbe19 to 6eef1a7 Compare November 21, 2024 01:49
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from 6eef1a7 to c331da8 Compare November 21, 2024 03:21
@andrewgazelka andrewgazelka changed the base branch from andrew/connect-alias to graphite-base/3349 November 21, 2024 04:13
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from c331da8 to 1e69e21 Compare November 21, 2024 04:16
@andrewgazelka andrewgazelka changed the base branch from graphite-base/3349 to main November 21, 2024 04:16
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from 1e69e21 to 06da35f Compare November 21, 2024 04:16
@github-actions github-actions bot added the enhancement New feature or request label Nov 21, 2024
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from 06da35f to c101750 Compare November 21, 2024 04:21
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 21, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3349 will not alter performance

Comparing andrew/connect-get-attr (d5b2d86) with main (e236332)

Summary

✅ 17 untouched benchmarks

@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from c101750 to 083d220 Compare November 21, 2024 05:18
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (e236332) to head (d5b2d86).
Report is 24 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
- Coverage   77.36%   77.35%   -0.01%     
==========================================
  Files         685      685              
  Lines       83639    83637       -2     
==========================================
- Hits        64704    64697       -7     
- Misses      18935    18940       +5

see 5 files with indirect coverage changes

@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from 083d220 to 4c4c192 Compare November 21, 2024 16:56
@andrewgazelka andrewgazelka force-pushed the andrew/connect-get-attr branch from 4c4c192 to d5b2d86 Compare November 21, 2024 18:45
@andrewgazelka andrewgazelka changed the title [FEAT] connect: df.get_attr [CHORE] connect test: df.get_attr Nov 26, 2024
@github-actions github-actions bot added the chore label Nov 26, 2024
@andrewgazelka andrewgazelka merged commit b201c61 into main Nov 26, 2024
47 checks passed
@andrewgazelka Graphite App
Copy link
Contributor Author

Merge activity

  • Nov 26, 9:00 AM EST: A user merged this pull request with Graphite.

@andrewgazelka andrewgazelka deleted the andrew/connect-get-attr branch November 26, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@universalmind303 universalmind303 universalmind303 approved these changes

Assignees
No one assigned
Labels
chore enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewgazelka @universalmind303