Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLOCKED!!! 🚧 [FEAT]: connect: df.sort #3357

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

update

419464b
Select commit
Loading
Failed to load commit list.
Draft

BLOCKED!!! 🚧 [FEAT]: connect: df.sort #3357

update
419464b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2024 in 0s

77.80% (-0.04%) compared to ae74c10

View this Pull Request on Codecov

77.80% (-0.04%) compared to ae74c10

Details

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 77.80%. Comparing base (ae74c10) to head (419464b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../daft-connect/src/translation/logical_plan/sort.rs 0.00% 41 Missing ⚠️
src/daft-connect/src/translation/logical_plan.rs 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3357      +/-   ##
==========================================
- Coverage   77.84%   77.80%   -0.04%     
==========================================
  Files         718      719       +1     
  Lines       88250    88295      +45     
==========================================
+ Hits        68696    68698       +2     
- Misses      19554    19597      +43     
Files with missing lines Coverage Δ
src/daft-connect/src/translation/logical_plan.rs 85.18% <0.00%> (-2.61%) ⬇️
.../daft-connect/src/translation/logical_plan/sort.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes