Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix build commit workflow #3487

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Dec 4, 2024

Overview

upload_wheel_to_s3.py script was updated to use the argparse module. However, consumers of this script were not updated; they were still using the old calling syntax.

This PR fixes that bug.

@github-actions github-actions bot added the bug Something isn't working label Dec 4, 2024
@raunakab raunakab enabled auto-merge (squash) December 4, 2024 03:29
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #3487 will degrade performances by 32.56%

Comparing bug/fix-build-commit-workflow (0645f3c) with main (988ee75)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bug/fix-build-commit-workflow Change
test_show[100 Small Files] 16.5 ms 24.5 ms -32.56%

@raunakab raunakab merged commit 6d30e30 into main Dec 4, 2024
42 of 43 checks passed
@raunakab raunakab deleted the bug/fix-build-commit-workflow branch December 4, 2024 03:50
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.33%. Comparing base (5ce91c8) to head (0645f3c).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3487      +/-   ##
==========================================
- Coverage   77.39%   77.33%   -0.07%     
==========================================
  Files         696      696              
  Lines       84549    84738     +189     
==========================================
+ Hits        65439    65528      +89     
- Misses      19110    19210     +100     

see 9 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant