Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Add a ray wait on metadatas when awaiting for tasks #3557

Closed
wants to merge 2 commits into from

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Dec 12, 2024

No description provided.

@github-actions github-actions bot added the perf label Dec 12, 2024
Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #3557 will degrade performances by 40.23%

Comparing jay/eager-ray-wait-metadata (a9c3e5d) with main (da6f499)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 25 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jay/eager-ray-wait-metadata Change
test_count[1 Small File] 3.9 ms 3.5 ms +10.81%
test_iter_rows_first_row[100 Small Files] 187.7 ms 314 ms -40.23%

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.79%. Comparing base (6ae4e77) to head (6adae15).

Files with missing lines Patch % Lines
daft/execution/execution_step.py 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3557   +/-   ##
=======================================
  Coverage   77.79%   77.79%           
=======================================
  Files         716      716           
  Lines       87770    87782   +12     
=======================================
+ Hits        68281    68293   +12     
  Misses      19489    19489           
Files with missing lines Coverage Δ
daft/runners/ray_runner.py 82.19% <100.00%> (+0.16%) ⬆️
daft/execution/execution_step.py 89.38% <83.33%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant