Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): add more unresolved functions #3618

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

andrewgazelka
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the feat label Dec 19, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #3618 will improve performances by 56.24%

Comparing andrew/connect-unresolved (747285c) with main (f6002f9)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main andrew/connect-unresolved Change
test_iter_rows_first_row[100 Small Files] 308.4 ms 197.4 ms +56.24%

@andrewgazelka andrewgazelka force-pushed the andrew/connect-unresolved branch from 8766efc to 2cd7a98 Compare December 19, 2024 21:22
@andrewgazelka andrewgazelka marked this pull request as ready for review December 19, 2024 21:22
@andrewgazelka andrewgazelka changed the title feat: add more unresolved functions feat(connect): add more unresolved functions Dec 19, 2024
Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small comments

Copy link
Contributor Author

@andrewgazelka andrewgazelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@andrewgazelka andrewgazelka enabled auto-merge (squash) December 19, 2024 21:40
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (07f6b2c) to head (747285c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...onnect/src/translation/expr/unresolved_function.rs 88.46% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3618      +/-   ##
==========================================
+ Coverage   77.84%   77.89%   +0.05%     
==========================================
  Files         719      719              
  Lines       88280    88421     +141     
==========================================
+ Hits        68720    68876     +156     
+ Misses      19560    19545      -15     
Files with missing lines Coverage Δ
...onnect/src/translation/expr/unresolved_function.rs 74.19% <88.46%> (+3.46%) ⬆️

... and 7 files with indirect coverage changes

@andrewgazelka andrewgazelka merged commit b87e0a3 into main Dec 19, 2024
42 checks passed
@andrewgazelka andrewgazelka deleted the andrew/connect-unresolved branch December 19, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants