Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix parquet benchmark test #3632

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Dec 20, 2024

@github-actions github-actions bot added the chore label Dec 20, 2024
@colin-ho colin-ho force-pushed the colin/fix-parquet-benchmark branch from a5b0366 to d3868d3 Compare December 20, 2024 22:22
Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #3632 will improve performances by 18.26%

Comparing colin/fix-parquet-benchmark (d3868d3) with main (f9a89a7)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main colin/fix-parquet-benchmark Change
test_iter_rows_first_row[100 Small Files] 230.1 ms 194.5 ms +18.26%

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (f9a89a7) to head (d3868d3).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3632   +/-   ##
=======================================
  Coverage   77.90%   77.90%           
=======================================
  Files         720      720           
  Lines       88726    88726           
=======================================
+ Hits        69122    69125    +3     
+ Misses      19604    19601    -3     

see 3 files with indirect coverage changes

@colin-ho colin-ho requested a review from raunakab January 6, 2025 19:05
@colin-ho colin-ho merged commit 836297a into main Jan 6, 2025
44 checks passed
@colin-ho colin-ho deleted the colin/fix-parquet-benchmark branch January 6, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants