Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(session): Adds session class to python #3809

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

rchowell
Copy link
Contributor

This PR adds the daft-session to the python APIs. It is an incremental step towards merging our session/catalog/table APIs. For a more complete picture of this class and its purpose, please see the full implementation at https://github.com/Eventual-Inc/Daft/blob/b29330ae0c22e325292599d75f6749175f2f12d1/daft/session.py

@rchowell rchowell requested a review from kevinzwang February 14, 2025 18:01
@github-actions github-actions bot added the feat label Feb 14, 2025
Copy link

codspeed-hq bot commented Feb 14, 2025

CodSpeed Performance Report

Merging #3809 will degrade performances by 39.53%

Comparing rchowell/session (400dc36) with main (f9a4b70)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 25 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_count[1 Small File] 3.9 ms 3.3 ms +19.77%
test_iter_rows_first_row[100 Small Files] 195 ms 322.6 ms -39.53%

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (f9a4b70) to head (400dc36).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
daft/session.py 82.14% 5 Missing ⚠️
daft/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3809      +/-   ##
==========================================
+ Coverage   75.60%   77.86%   +2.25%     
==========================================
  Files         748      750       +2     
  Lines       99035    94774    -4261     
==========================================
- Hits        74875    73793    -1082     
+ Misses      24160    20981    -3179     
Files with missing lines Coverage Δ
src/daft-session/src/python.rs 100.00% <100.00%> (ø)
src/lib.rs 96.20% <100.00%> (+0.04%) ⬆️
daft/__init__.py 23.07% <0.00%> (-0.61%) ⬇️
daft/session.py 82.14% <82.14%> (ø)

... and 34 files with indirect coverage changes

@rchowell rchowell merged commit e6db43b into main Feb 14, 2025
43 of 44 checks passed
@rchowell rchowell deleted the rchowell/session branch February 14, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants