Feat/window functions skeleton #3811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.rs and cleanup style
- Add hash-based deduplication in set_agg.rs - Add proper null value handling in set operations - Add debug logging for set operations - Improve error messaging for unhashable types - Update tests to verify set aggregation behavior
- Remove daft-functions from daft-table dependencies - Remove daft-functions/python from python feature
…id unnecessary copies
…uplication to agg.rs
…and skip list/struct set aggs tests
CodSpeed Performance ReportMerging #3811 will degrade performances by 29.74%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds skeleton code for window functions in Daft, focusing on the Python-side API structure. Changes include:
Added
Windowclass with basic window specification stubs:partition_by(),order_by()rows_between(),range_between()Added
over()method to Expression class for applying window functionsThe actual implementations will be added in Rust in subsequent PRs. This PR only establishes the Python API structure to allow the test files to compile.
Testing
Added test files under tests/window/ that define the expected behavior for various window operations. Tests currently have placeholder assertions that will be updated once the Rust implementations are added.