Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog): Prepare existing catalog APIs for integration [1/3] #3820

Merged
merged 6 commits into from
Feb 20, 2025

Adds public Catalog from_ methods

1b0ab2d
Select commit
Loading
Failed to load commit list.
Merged

feat(catalog): Prepare existing catalog APIs for integration [1/3] #3820

Adds public Catalog from_ methods
1b0ab2d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 19, 2025 in 0s

78.03% (+0.13%) compared to b34c2bf

View this Pull Request on Codecov

78.03% (+0.13%) compared to b34c2bf

Details

Codecov Report

Attention: Patch coverage is 62.11180% with 61 lines in your changes missing coverage. Please review.

Project coverage is 78.03%. Comparing base (b34c2bf) to head (1b0ab2d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
daft/catalog/__unity.py 54.90% 23 Missing ⚠️
daft/catalog/__init__.py 74.54% 14 Missing ⚠️
daft/catalog/__iceberg.py 69.04% 13 Missing ⚠️
daft/catalog/pyiceberg.py 0.00% 4 Missing ⚠️
daft/catalog/unity.py 0.00% 4 Missing ⚠️
daft/catalog/python_catalog.py 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3820      +/-   ##
==========================================
+ Coverage   77.89%   78.03%   +0.13%     
==========================================
  Files         751      754       +3     
  Lines       94879    95258     +379     
==========================================
+ Hits        73905    74333     +428     
+ Misses      20974    20925      -49     
Files with missing lines Coverage Δ
src/daft-catalog/src/python.rs 61.76% <100.00%> (+0.57%) ⬆️
daft/catalog/python_catalog.py 0.00% <0.00%> (ø)
daft/catalog/pyiceberg.py 0.00% <0.00%> (ø)
daft/catalog/unity.py 0.00% <0.00%> (ø)
daft/catalog/__iceberg.py 69.04% <69.04%> (ø)
daft/catalog/__init__.py 76.66% <74.54%> (+24.20%) ⬆️
daft/catalog/__unity.py 54.90% <54.90%> (ø)

... and 18 files with indirect coverage changes