Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Emit smaller side in hash join #3964

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Mar 11, 2025

This brings down Q5 (SQL + join ordering) down from 150s -> 67s.

@github-actions github-actions bot added the perf label Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.53%. Comparing base (0f80380) to head (ded395b).

Files with missing lines Patch % Lines
src/daft-physical-plan/src/ops/hash_join.rs 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3964      +/-   ##
==========================================
+ Coverage   78.51%   78.53%   +0.01%     
==========================================
  Files         774      774              
  Lines       98542    98554      +12     
==========================================
+ Hits        77374    77395      +21     
+ Misses      21168    21159       -9     
Files with missing lines Coverage Δ
daft/execution/physical_plan.py 94.53% <100.00%> (+<0.01%) ⬆️
daft/execution/rust_physical_plan_shim.py 95.60% <ø> (ø)
src/daft-scheduler/src/scheduler.rs 92.99% <100.00%> (+0.02%) ⬆️
src/daft-physical-plan/src/ops/hash_join.rs 39.68% <88.88%> (+8.20%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant