Make ModAsset.Deserialize throw exceptions on failure
#844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we need to search for mods using ModAsset.Deserialize to pull this PR out of review hell? |
maddie480
added
discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModAsset.Deserialize<T>()usesModAsset.TryDeserialize<T>(out T), which suppresses all exceptions when deserializing YAML.This can hinder debugging if deserialization is failing for whatever reason, as the exception info is now lost.
This PR causes
ModAsset.Deserialize<T>()to now throw exceptions, if deserialization fails.(Mods depending on
ModAsset.Deserialize<T>()could break because of that, which is why this is a draft.)