Add cassette fly check to Player.OnSquish #846
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cassette fly state is intended to make the player invincible, but at the moment squish checks are still made against the player. This can cause deaths in modded situations when the return path crosses e.g. block entities. This path adds a check at the start of OnSquish to return immediately if the player is in the CassetteFly state.
microlith57
approved these changes
Nov 7, 2024
| cursor.EmitLdarg(0); | ||
| cursor.EmitLdfld(f_Player_StateMachine); | ||
| cursor.EmitCallvirt(m_StateMachine_get_State); | ||
| cursor.EmitLdcI4(21); |
There was a problem hiding this comment.
minor nitpick:
Suggested change
| cursor.EmitLdcI4(21); | |
| cursor.EmitLdcI4(21 /* StCassetteFly */); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cassette fly state is intended to make the player invincible, but at the moment squish checks are still made against the player. This can cause deaths in modded situations when the return path crosses e.g. block entities.
This patch adds a check at the start of OnSquish to return immediately if the player is in the CassetteFly state.
Here is an example of the behavior before the change and after the change.
(This change was made manually in SJ and I thought it'd be helpful to add into Everest as a whole)