Add Entity Collider Components to Entities #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psyGamer
reviewed
Nov 30, 2024
JaThePlayer
requested changes
Nov 30, 2024
… date, especially if a Scene change happens
…way the Tracker's Initializer works, plus method to include all or no subtypes
JaThePlayer
requested changes
Dec 1, 2024
psyGamer
requested changes
Dec 1, 2024
…ain without type being added to Tracker first
…if added mid-scene and EntityAwake if added pre-scene
|
don't think generic type can be tracked |
JaThePlayer
reviewed
Dec 2, 2024
JaThePlayer
approved these changes
Dec 3, 2024
|
USSRNAME (wuke32767) wants to provide a pull request to my changes so if changes come in, it's their pull request code and will be added to the conversation because it includes some MonoMod things I don't fully understand |
use version to determine if tracker is outdated
… to prevent refreshes immediately after creation
psyGamer
requested changes
Dec 9, 2024
…Scene if not passed
psyGamer
approved these changes
Dec 9, 2024
|
This is ready for final review / merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making this to fulfill an idea for a single part of my mod, I instead generalized the idea and made it in such a way that having it in Everest would be useful for anyone.
The 2 components added, EntityCollider and EntityColliderByComponent, work in the same way a PlayerCollider or PufferCollider work in vanilla, except they are made so they can instead collide with any entity as defined with the generic type parameter. Entity Collider collides based on Entity, EntityColliderByComponent collides based on if an entity has the component of type.
Additionally, two methods were added to patch_Tracker: AddEntityToTracker and AddColliderToTracker. This allows for any type that is not normally tracked to become tracked and have its entities added to the Tracker. This is done in conjunction to the Entity Colliders due to performance, so it's not required to look through the Scene's Entities every single Update call. Some entities, like Springs, aren't tracked, but are a good candidate for something you'd want to collide with. This is why these methods were made. If anyone thinks this can be unsafe, anyone can find any entity anyways by going through Scene.Entities, so it does not add any vulnerability to normally untracked entities.