Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binary-install dependencies to address CVE on axios #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cellule
Copy link

@Cellule Cellule commented Nov 23, 2023

There's a vulnerability on axios
https://cve.mitre.org/cgi-bin/cvename.cgi?name=2023-45857
I also looked at updating the other dependencies.
This might require a major bump on binary-install since rimraf dropped support for node 14 effectively making this project also requiring node 14+
The other breaking changes on rimraf seemed minimal, only the removal of default export seems to affect this project.

It seems I also bumped the lockfile version, it should be a transparent change

@ptakizawa-daitan
Copy link

Hey, any idea on when this PR will be merged?

@reknih
Copy link

reknih commented Nov 1, 2024

We'd also like to see this PR merged! I'm aware that most people run binary-install as a dev dependency and the real-world impact is probably close to zero -- however, the vulnerability clutters the output of automatic scanning tools such as npm audit and lessens visibility of true vulnerabilities.

IMHO the bump of the minimum Node version to Node 14 is justifiable. Node 14 released more than four years ago, its support ended more than 550 days ago at the time of writing, so most users of this library that will bump their lock file are likely to be on Node 18 or newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants