Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings for functions and blocks with no parameters #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions evernote-sdk-ios/ENSDK/Advanced/ENNoteStoreClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -962,7 +962,7 @@ DEPRECATED_MSG_ATTRIBUTE("Use -createTag:completion: instead") NS_SWIFT_UNAVAILA
DEPRECATED_MSG_ATTRIBUTE("Use -updateTag:completion: instead") NS_SWIFT_UNAVAILABLE("Deprecated");

- (void)untagAllWithGuid:(EDAMGuid)guid
success:(void(^)())success
success:(void(^)(void))success
failure:(void(^)(NSError *error))failure
DEPRECATED_MSG_ATTRIBUTE("Use -untagAllWithGuid:completion: instead") NS_SWIFT_UNAVAILABLE("Deprecated");

Expand Down Expand Up @@ -1256,7 +1256,7 @@ DEPRECATED_MSG_ATTRIBUTE("Use -authenticateToSharedNotebook:completion: instead"
DEPRECATED_MSG_ATTRIBUTE("Use -getSharedNotebookByAuthWithCompletion: instead") NS_SWIFT_UNAVAILABLE("Deprecated");

- (void)emailNoteWithParameters:(EDAMNoteEmailParameters *)parameters
success:(void(^)())success
success:(void(^)(void))success
failure:(void(^)(NSError *error))failure
DEPRECATED_MSG_ATTRIBUTE("Use -emailNoteWithParameters:completion: instead") NS_SWIFT_UNAVAILABLE("Deprecated");

Expand All @@ -1266,7 +1266,7 @@ DEPRECATED_MSG_ATTRIBUTE("Use -emailNoteWithParameters:completion: instead") NS_
DEPRECATED_MSG_ATTRIBUTE("Use -shareNoteWithGuid:completion: instead") NS_SWIFT_UNAVAILABLE("Deprecated");

- (void)stopSharingNoteWithGuid:(EDAMGuid)guid
success:(void(^)())success
success:(void(^)(void))success
failure:(void(^)(NSError *error))failure
DEPRECATED_MSG_ATTRIBUTE("Use -stopSharingNoteWithGuid:completion: instead") NS_SWIFT_UNAVAILABLE("Deprecated");

Expand Down
6 changes: 3 additions & 3 deletions evernote-sdk-ios/ENSDK/Advanced/ENNoteStoreClient.m
Original file line number Diff line number Diff line change
Expand Up @@ -1023,7 +1023,7 @@ - (void)updateTag:(EDAMTag *)tag
}

- (void)untagAllWithGuid:(EDAMGuid)guid
success:(void(^)())success
success:(void(^)(void))success
failure:(void(^)(NSError *error))failure
{
[self untagAllWithGuid:guid completion:^(NSError * _Nonnull error) {
Expand Down Expand Up @@ -1569,7 +1569,7 @@ - (void)getSharedNotebookByAuthWithSuccess:(void(^)(EDAMSharedNotebook *sharedNo
}

- (void)emailNoteWithParameters:(EDAMNoteEmailParameters *)parameters
success:(void(^)())success
success:(void(^)(void))success
failure:(void(^)(NSError *error))failure
{
[self emailNoteWithParameters:parameters completion:^(NSError * _Nonnull error) {
Expand All @@ -1587,7 +1587,7 @@ - (void)shareNoteWithGuid:(EDAMGuid)guid
}

- (void)stopSharingNoteWithGuid:(EDAMGuid)guid
success:(void(^)())success
success:(void(^)(void))success
failure:(void(^)(NSError *error))failure
{
[self stopSharingNoteWithGuid:guid completion:^(NSError * _Nonnull error) {
Expand Down
2 changes: 1 addition & 1 deletion evernote-sdk-ios/ENSDK/Advanced/ENUserStoreClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ NS_ASSUME_NONNULL_BEGIN
DEPRECATED_MSG_ATTRIBUTE("Use -authenticateToBusinessWithCompletion: instead") NS_SWIFT_UNAVAILABLE("Deprecated");

- (void)revokeLongSessionWithAuthenticationToken:(NSString*)authenticationToken
success:(void(^)())success
success:(void(^)(void))success
failure:(void(^)(NSError *error))failure
DEPRECATED_MSG_ATTRIBUTE("Use -revokeLongSessionWithAuthenticationToken:completion: instead") NS_SWIFT_UNAVAILABLE("Deprecated");
@end
Expand Down
2 changes: 1 addition & 1 deletion evernote-sdk-ios/ENSDK/Advanced/ENUserStoreClient.m
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ - (void)authenticateToBusinessWithSuccess:(void(^)(EDAMAuthenticationResult *aut
}

- (void)revokeLongSessionWithAuthenticationToken:(NSString*)authenticationToken
success:(void(^)())success
success:(void(^)(void))success
failure:(void(^)(NSError *error))failure {
[self revokeLongSessionWithAuthenticationToken:authenticationToken completion:^(NSError *error) {
(error == nil) ? success() : failure(error);
Expand Down
4 changes: 2 additions & 2 deletions evernote-sdk-ios/ENSDK/ENCommonUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

@interface ENCommonUtils : NSObject

BOOL IsIOS8();
BOOL IsEvernoteInstalled();
BOOL IsIOS8(void);
BOOL IsEvernoteInstalled(void);

@end
4 changes: 2 additions & 2 deletions evernote-sdk-ios/ENSDK/Private/ENStoreClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ extern NSString * ENStoreClientDidFailWithAuthenticationErrorNotification;

@interface ENStoreClient : NSObject

- (void)invokeAsyncBoolBlock:(BOOL(^)())block completion:(void (^)(BOOL value, NSError *_Nullable error))completion;
- (void)invokeAsyncBoolBlock:(BOOL(^)(void))block completion:(void (^)(BOOL value, NSError *_Nullable error))completion;
- (void)invokeAsyncObjectBlock:(nullable id(^)())block completion:(void (^)(id _Nullable value, NSError *_Nullable error))completion;
- (void)invokeAsyncInt32Block:(int32_t(^)())block completion:(void (^)(int32_t value, NSError *_Nullable error))completion;
- (void)invokeAsyncInt32Block:(int32_t(^)(void))block completion:(void (^)(int32_t value, NSError *_Nullable error))completion;
- (void)invokeAsyncBlock:(void(^)())block completion:(void (^)(NSError *_Nullable error))completion;

@end
Expand Down
4 changes: 2 additions & 2 deletions evernote-sdk-ios/ENSDK/Private/ENStoreClient.m
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ - (id)init
return self;
}

- (void)invokeAsyncBoolBlock:(BOOL(^)())block completion:(void (^)(BOOL val, NSError *error))completion
- (void)invokeAsyncBoolBlock:(BOOL(^)(void))block completion:(void (^)(BOOL val, NSError *error))completion
{
dispatch_async(self.queue, ^(void) {
__block BOOL retVal = NO;
Expand All @@ -68,7 +68,7 @@ - (void)invokeAsyncBoolBlock:(BOOL(^)())block completion:(void (^)(BOOL val, NSE
});
}

- (void)invokeAsyncInt32Block:(int32_t(^)())block completion:(void (^)(int32_t val, NSError *_Nullable error))completion
- (void)invokeAsyncInt32Block:(int32_t(^)(void))block completion:(void (^)(int32_t val, NSError *_Nullable error))completion
{
dispatch_async(self.queue, ^(void) {
__block int32_t retVal = -1;
Expand Down