Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev.ej/fix docs ci #618

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Dev.ej/fix docs ci #618

merged 2 commits into from
Jan 9, 2025

Conversation

joanise
Copy link
Member

@joanise joanise commented Jan 7, 2025

PR Goal?

Deploy docs CI workflow was broken: see https://github.com/EveryVoiceTTS/EveryVoice/actions/runs/12655263006 which failed on the last push to main.

We updated all our other workflow to use setup-python instead of conda incubator, this PR does the same for the deploy docs workflows.

Fixes?

Broken docs deploy

Feedback sought?

sanity checking

Priority?

before the next PR merge to main, ideally

Tests added?

https://github.com/EveryVoiceTTS/EveryVoice/actions/runs/12656113424 ran with the docs deploy workflow, but with --push removed so it didn't push, and it completed successfully.

Confidence?

high

Version change?

no

Related PRs?

no

Copy link

Review changes with  SemanticDiff

Copy link
Contributor

github-actions bot commented Jan 7, 2025

CLI load time: 0:00.27
Pull Request HEAD: 77be9ef54d956f5da2edede18cc82d99f148a6eb
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1064 |     106436 |     typer.main
import time:       283 |     125633 |   typer
import time:      7623 |     204503 | everyvoice.cli

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.78%. Comparing base (3a74d7c) to head (77be9ef).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #618   +/-   ##
=======================================
  Coverage   76.78%   76.78%           
=======================================
  Files          47       47           
  Lines        3450     3450           
  Branches      470      470           
=======================================
  Hits         2649     2649           
  Misses        700      700           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I didn't notice. thanks @joanise !

@joanise joanise merged commit 155f4fb into main Jan 9, 2025
6 checks passed
@joanise joanise deleted the dev.ej/fix-docs-ci branch January 9, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants