Fix counter-orientation-direction operations on some devices #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces (like Google Pixel 4, Huawei P40 Lite)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that on some devices the counter-orientation-direction operations does not work.
After short debugging I have noticed that
dxanddyare equal to 0 at the beginning of dragging on these devices and therefore it's not triggering theMath.abs(dx) > Math.abs(dy)condition. In order to fix this issue I have added zero check ondxanddy.Tested on Samsung Galaxy S8, Samsung Galaxy S20+, Samsung Galaxy A6, Sony Xperia Z2, Huawei P40 Lite and Google Pixel 4. Problem occured only on last two of them. Now it works good on all these devices.