Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added insult per day notification feature #190

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

indra057
Copy link
Contributor

@indra057 indra057 commented Oct 5, 2024

#41
added insult of the day functionality

  1. created notification channel(for android oreo and above)(in extensions/Notification.kt)
    2.checks whether notification permission present or not(in MainActivity.kt)
    3.WorkerManager schedules the notification to 1 notification per day (in extensions/NotificationWorker.kt)

@EvilInsultGenerator please check if everything is working and what are the things i need to further change or if any bug exist before merging the pull request

@indra057
Copy link
Contributor Author

indra057 commented Oct 6, 2024

@EvilInsultGenerator sir some checks of above pr has failed can u please describe me the issue so that i can fix the issue

@EvilInsultGenerator
Copy link
Owner

Thanks for the PR.

May you please add an option for this feature?
What do you think about a checkbox below Legal?
Notification
By default, the option should be disabled.

You may find the Codacy issues on https://app.codacy.com/gh/EvilInsultGenerator/android-app/pull-requests/190/issues. We may ignore them. Most functions don't have a documentation.

@indra057
Copy link
Contributor Author

indra057 commented Oct 6, 2024

@EvilInsultGenerator sir i didn't understood what u are saying... should i add extra feature that u showed in the screenshot that fixes my above issue(some checks failed) or is this another feature that u want me to implement and is independent of my pr...

@EvilInsultGenerator
Copy link
Owner

The Insult of the day notification should be optional and disabled by default.
So we need a way for the user to switch it on/off.

@indra057
Copy link
Contributor Author

indra057 commented Oct 6, 2024

@EvilInsultGenerator okk sir i will work on it..may take some time

@EvilInsultGenerator
Copy link
Owner

Don't worry, take your time. 👍

@EvilInsultGenerator EvilInsultGenerator linked an issue Dec 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insult-of-the-Day notifications
2 participants