Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EP-1101 more tweaks to the order api docs #59

Merged
merged 2 commits into from
May 13, 2024
Merged

EP-1101 more tweaks to the order api docs #59

merged 2 commits into from
May 13, 2024

Conversation

miguel-evocalize
Copy link

  1. Fix audience path
  2. Add EV_BAD_REQUEST_INVALID_USER_IDENTITY error code
  3. Add missing response status to GET order endpoints
  4. Remove 404 response status from place subscription order endpoint

@miguel-evocalize miguel-evocalize requested review from a team, sharatvisweswara, tyler-evocalize and jim-evocalize and removed request for a team May 13, 2024 16:22
tyler-evocalize
tyler-evocalize approved these changes May 13, 2024
View reviewed changes
Copy link

@tyler-evocalize tyler-evocalize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what / why the build is failing :|

@miguel-evocalize
Copy link
Author

Not sure what / why the build is failing :|

I tweaked the github build.yml and looks like the builds are passing now!

@miguel-evocalize miguel-evocalize merged commit 12c9dc2 into main May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyler-evocalize tyler-evocalize tyler-evocalize approved these changes

@sharatvisweswara sharatvisweswara Awaiting requested review from sharatvisweswara sharatvisweswara was automatically assigned from Evocalize/backend

@jim-evocalize jim-evocalize Awaiting requested review from jim-evocalize jim-evocalize was automatically assigned from Evocalize/backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguel-evocalize @tyler-evocalize