Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InternVL2 model sharding #481

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Fix InternVL2 model sharding #481

merged 1 commit into from
Dec 28, 2024

Conversation

pufanyi
Copy link
Collaborator

@pufanyi pufanyi commented Dec 27, 2024

As described in here and here

The reason for writing the code this way is to avoid errors that occur during multi-GPU inference due to tensors not being on the same device. By ensuring that the first and last layers of the large language model (LLM) are on the same device, we prevent such errors.

@pufanyi pufanyi requested a review from Luodian December 27, 2024 15:59
@Luodian Luodian merged commit b9b3c1a into main Dec 28, 2024
2 checks passed
@pufanyi pufanyi deleted the pufanyi/internvl2 branch December 28, 2024 07:13
kcz358 pushed a commit that referenced this pull request Dec 30, 2024
@pufanyi @kcz358
Fix InternVL2 model sharding (#481)
75f4536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luodian Luodian Luodian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pufanyi @Luodian