[FIX] Minor errors in gemini_api.py
and internvl2.py
.
#502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two minor errors in models.
Initialize
self.response_persistent_file
ingemini_api.py
GeminiAPI
withcontinual_mode=False
, It causes ValueError sinceself.response_persistent_file
is not declared.lmms-eval/lmms_eval/models/gemini_api.py
Lines 58 to 64 in 8821357
self.response_persistent_file
with an empty string (""
) to prevent error.Wrong variable name in
internvl2.py
internvl2.py
,self.model.chat()
in line 316 requiresnum_patches_list
variable.num_patch_list
instead ofnum_patches_list
.lmms-eval/lmms_eval/models/internvl2.py
Lines 313 to 316 in 8821357
BTW, Happy New Year!