Adding a dynamic stress (wave model) to wall_models

[ayalamanuel]

Summary

We have introduced a dynamic stress as a wall model. the dynamic stress calculates the stress due to waves. a new struct was implemented in ShearStressSimple.H where the wave stress is calculated. a new header (MOSD.H) was created with the calculations of the stress. the WallFunction.cpp has been modified accordingly.

Unit testing (test_mosd.cpp) and regression testing (channel_mosd.inp) using CPU has been done and added. The documentation of the model has also been added in the inputs_Boundary_conditions.rst file.

Pull request type

Please check the type of change introduced:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Checklist

The following is included:

• new unit-test(s)
• new regression test(s)
• documentation for new capability

This PR was tested by running:

• the unit tests
  • on GPU
  • on CPU
• the regression tests
  • on GPU
  • on CPU

Additional background

Issue Number:

[marchdf]

Quick list of things to do (I am sure you are working on these):

• documentation
• reg test
• unit test

I can look at the PR in detail later this week. Thank you for working on this!

[marchdf]

@ayalamanuel do you have any updates on this?

[ayalamanuel]

@marchdf Old files have been updated. Unit test, regression test and documentation have been added. Thanks!

[ayalamanuel]

I've made the modifications to all the comments made @marchdf

[marchdf]

A meta comment here: to get past the CI check, the first thing you need to do is format your code. You can do that automatically with clang-format: https://exawind.github.io/amr-wind/developer/coding_guidelines.html#style-guide-recommendations

[moprak-nrel]

I think the interpolation logic looks a lot better! Here's a few more minor comments on the interpolation

[moprak-nrel]

I'm curious, when do we expect this branch to occur?

[moprak-nrel]

Looking through the changes, did this get resolved?

[ayalamanuel]

I believe it did get solve. Or perhaps I am not understanding the issue

[moprak-nrel]

I'm trying to figure out when this branch will occur with all the new interpolation changes.

[marchdf]

Can I do anything to help push this through? We are super close I think.

[ayalamanuel]

@marchdf @moprak-nrel sorry for taking so long with this! Hopefully it's almost finished

[marchdf]

can you resolve those documentation conflicts?

[ayalamanuel]

seems like the documentation issues are because I used and outdated theory.rst file. How can I update that file in my branch? then I can just add the once again the new part of documentation from my implementation

[moprak-nrel]

seems like the documentation issues are because I used and outdated theory.rst file. How can I update that file in my branch? then I can just add the once again the new part of documentation from my implementation

I would rebase your branch with the latest amr-wind main and resolve any conflicts there. You'll need to do this before the PR is ready for merging anyway.