Forest Canopy Model #1324
Open
Forest Canopy Model #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sample result. Top is a heterogeneous tree model while other three are homogeneous. |
marchdf
requested changes
Nov 4, 2024
|
|
||
| namespace amr_wind::pde::icns { | ||
|
|
||
| /** Adds the forcing term to include the presence of immersed boundary |
amr-wind/physics/ForestDrag.H
Outdated
| amrex::Vector<amrex::Real> m_x_forest; | ||
| amrex::Vector<amrex::Real> m_y_forest; | ||
| amrex::Vector<amrex::Real> m_ht_forest; | ||
| amrex::Vector<amrex::Real> m_dia_forest; |
There was a problem hiding this comment.
if dia is diameter, spell it out?
amr-wind/physics/ForestDrag.H
Outdated
| amrex::Vector<amrex::Real> m_type_forest; | ||
| amrex::Vector<amrex::Real> m_x_forest; | ||
| amrex::Vector<amrex::Real> m_y_forest; | ||
| amrex::Vector<amrex::Real> m_ht_forest; |
amr-wind/physics/ForestDrag.H
Outdated
| amrex::Vector<amrex::Real> m_dia_forest; | ||
| amrex::Vector<amrex::Real> m_cd_forest; | ||
| amrex::Vector<amrex::Real> m_lai_forest; | ||
| amrex::Vector<amrex::Real> m_lm_forest; |
amr-wind/physics/ForestDrag.cpp
Outdated
| levelDrag(i, j, k) = 0.0; | ||
| for (unsigned ii = 0; ii < forestSize; ++ii) { | ||
| const amrex::Real radius = std::sqrt( | ||
| std::pow(x - x_forest_ptr[ii], 2) + |
There was a problem hiding this comment.
pow 2 should be written out as x * x for performance.
| const amrex::Real y = prob_lo[1] + (j + 0.5) * dx[1]; | ||
| const amrex::Real z = prob_lo[2] + (k + 0.5) * dx[2]; | ||
| levelDrag(i, j, k) = 0.0; | ||
| for (unsigned ii = 0; ii < forestSize; ++ii) { |
There was a problem hiding this comment.
I don't like this for loop combined with the while loop below. Let's chat and see if we can come up with something better.
Co-authored-by: Marc T. Henry de Frahan <[email protected]>
Co-authored-by: Marc T. Henry de Frahan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a forest canopy model in AMR-Wind. Two kinds of forests are supported: (i) homogeneous forest and (ii) heterogeneous forest using an empirical model for leaf area density.
Forest overlap is allowed and is not checked. It is expected that the users provide accurate inputs and currently no checking is included. The model requires following inputs from the user: (i) tree type (ii) tree center x (iii) tree center y (iv) tree height (v) tree girth preferably at the widest point (vi) tree drag coefficient (vii) tree leaf area index (viii) location of maximum leaf area density for heterogeneous forests.
The model will work with any LES model as the drag forcing due to the turbulence is required only in momentum equation. It is also possible to include a turbulence forcing term in one equation kegs model.
The model will be extended to the one-equation RANS model in a future PR by including the turbulence contribution.
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Issue Number: #1322