Quaternion from tangent and twist #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/math/quaternion_operations.hpp
Outdated
Comment on lines
65
to
72
| size_t max_idx{0}; | ||
| double max_num{vals[0]}; | ||
| for (auto i = 1U; i < vals.size(); ++i) { | ||
| if (vals[i] > max_num) { | ||
| max_idx = i; | ||
| max_num = vals[i]; | ||
| } | ||
| } |
There was a problem hiding this comment.
I believe there exists an std algorithm to do this, which we could utilize rather than rolling out our own.
auto max_element_iter = std::max_element(vals.begin(), vals.end());
auto max_idx = std::distance(vals.begin(), max_element_iter);
auto max_num = *max_element_iter;
src/math/quaternion_operations.hpp
Outdated
Comment on lines
315
to
316
| -a * e1[1] / sqrt(e1[0] * e1[0] + e1[1] * e1[1]), | ||
| a * e1[0] / sqrt(e1[0] * e1[0] + e1[1] * e1[1]), |
There was a problem hiding this comment.
Couple comments
- This returns
NaNwhen the tangent is the z-axis, i.e.e1 = e2 = 0.-- we should probably check for div by zero here - We could simplify this by introducing a local variable as such
const auto denominator = std::sqrt(e1[0] * e1[0] + e1[1] * e1[1]);
const Array_3 e2{
-a * e1[1] / denominator,
a * e1[0] / denominator,
0.,
};
|
I think that I've addressed the comments, please take another look. |
faisal-bhuiyan
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to compute quaternion from material axis tangent and twist parameter.